Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extractors for EVT, EVTX, SQLITE added along with some extra signatures. #880

Merged
merged 4 commits into from
Nov 8, 2019

Conversation

n1073645
Copy link
Contributor

@n1073645 n1073645 commented Nov 8, 2019

EVT, EVTX, SQLITE extractors.
Extra signatures which include shebangs for python, perl, bash/sh and Ruby.

@n1073645 n1073645 requested a review from n1474335 November 8, 2019 17:16
Copy link
Member

@n1474335 n1474335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice work!

@n1474335 n1474335 merged commit eb81b92 into gchq:master Nov 8, 2019
while (stream.hasMore()) {

// Loop through ELFCHNKs.
if (stream.getBytes(7).join("") === [0x45, 0x6c, 0x66, 0x43, 0x68, 0x6e, 0x6b].join(""))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBytes consumes those bytes, so if we don't find this pattern, do we need to move backwards by 7 bytes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants